Implement RFC 018 common scalar catalog#54
Draft
dannymeijer wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the remaining RFC 018 common scalar catalog work after the earlier math slice. This adds registry-backed math, string, text encoding, regex, date/time, and compatibility alias helpers, keeps Substrait mappings registry-owned, and adds DataFusion adapter UDFs only where the first backend does not expose a direct API-level equivalent for the InQL contract.
Follow-up review polish in the latest commit keeps
concat(...)andconcat_ws(...)as variadic helper surfaces, removes redundant DataFusion adapter UDF wrapper code, and tightens regex docs so the portable contract is Rust-regex-compatible rather than DataFusion-owned.Type of change
docs/rfcs/*)Area(s)
Key details
substr,ucase,lcase,dateadd,datediff, andsafe_cast.Testing / verification
make fmtmake fmt-checkmake test-stylemake registry-metadatamake buildmake testmake smoke-consumermake pre-commitManual verification notes:
/Users/danny/Development/encero/incan/target/debug/incanfrom Incanrelease/v0.3/0.3.0-rc30.incan test tests/test_common_scalar_functions.incn,incan test tests/test_function_registry.incn,incan test tests/test_substrait_plan.incn, andincan test tests/test_session_projection.incn.make testpassed: 194 tests.make smoke-consumer INCAN=/Users/danny/Development/encero/incan/target/debug/incanpassed with network access for crates.io resolution.make pre-commitpassed, including format, test-style, registry metadata, build, and the 194-test suite.git diff --checkpassed.Docs impact
If docs updated:
docs/rfcs/018_common_scalar_function_catalog.md,docs/rfcs/013_function_catalog_program.md,docs/language/reference/functions/index.md,docs/release_notes/v0_1.mdChecklist
Closes #35.