Repository navigation
ci(mac): verify real DMG Sparkle signature on hosted runner - #380
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a dispatch-only macOS CI check that builds a 0.4.0 DMG on a GitHub-hosted runner, signs that exact DMG with the existing
SPARKLE_ED_PRIVATE_KEYActions secret, and verifies the appcast's Ed25519 signature against the DMG bytes and the public key inside its packaged app. It does not publish a release or update feed.Scope and guardrails
workflow_dispatchonly, with a required exact 40-characterexpected_commitinput. The job runs only fordanjboyd/ScreenshotToolonrefs/heads/mainand fails unless the checkout,GITHUB_SHA, and input match.CFBundleVersioncomes from the checked-out commit count. The source and packaged app must carry the existingSUPublicEDKey.sign_updateSHA-25643c249771bafc3aa581228abae00731a012d324691b8292860896635050be76bbefore signing. Fail on an empty secret instead of falling back to a local keychain.SHA256SUMS, the unpublished appcast, and the verifier's text output. The signed DMG is not uploaded.actions/checkout@v4andactions/upload-artifact@v4use the same tag-level action pinning as the existing release workflow. Full commit-SHA action pinning is outside this change.Verification and limits