Skip to content

ci(mac): verify real DMG Sparkle signature on hosted runner - #380

Merged
danjboyd merged 1 commit into
mainfrom
ci/macos-real-dmg-proof
Nov 18, 2026
Merged

danjboyd merged 1 commit into
mainfrom
ci/macos-real-dmg-proof

Conversation

@danjboyd

Copy link
Copy Markdown
Owner

Summary

Add a dispatch-only macOS CI check that builds a 0.4.0 DMG on a GitHub-hosted runner, signs that exact DMG with the existing SPARKLE_ED_PRIVATE_KEY Actions secret, and verifies the appcast's Ed25519 signature against the DMG bytes and the public key inside its packaged app. It does not publish a release or update feed.

Scope and guardrails

  • workflow_dispatch only, with a required exact 40-character expected_commit input. The job runs only for danjboyd/ScreenshotTool on refs/heads/main and fails unless the checkout, GITHUB_SHA, and input match.
  • Build version is fixed to 0.4.0; CFBundleVersion comes from the checked-out commit count. The source and packaged app must carry the existing SUPublicEDKey.
  • Fetch Sparkle without the secret, then verify sign_update SHA-256 43c249771bafc3aa581228abae00731a012d324691b8292860896635050be76b before signing. Fail on an empty secret instead of falling back to a local keychain.
  • Verify the exact generated DMG inside the job. The one-day artifact contains only SHA256SUMS, the unpublished appcast, and the verifier's text output. The signed DMG is not uploaded.
  • actions/checkout@v4 and actions/upload-artifact@v4 use the same tag-level action pinning as the existing release workflow. Full commit-SHA action pinning is outside this change.

Verification and limits

  • Source review: the Swift verifier typechecks on macOS; the workflow YAML parses. The workflow has not been published or dispatched, and this change by itself provides no real-secret or final-release proof.
  • The check will prove the DMG made in its own run. A separately rebuilt release DMG and published feed still need public-key verification against their exact bytes before the feed moves.
  • A later, separate approval will name the post-Windows: Edit menu appeared greyed out once #354 main SHA and authorize one dispatch. This PR does not authorize dispatch, signing, tagging, release, Pages deployment, or feed publication.

@danjboyd
danjboyd merged commit 4550277 into main Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant