Skip to content

Read Sparkle's namespaced signed length in the key-match verifier - #378

Merged
danjboyd merged 1 commit into
mainfrom
fix/sparkle-keymatch-length
Nov 11, 2026
Merged

danjboyd merged 1 commit into
mainfrom
fix/sparkle-keymatch-length

Conversation

@danjboyd

Copy link
Copy Markdown
Owner

Summary

  • Read Sparkle 2.10's sparkle:length attribute from sign_update output. The previous bare length lookup failed before the dummy proof reached Ed25519 verification in run 43075103781.
  • Keep the payload, public key, signature length, and Ed25519 checks in their existing order. The revised error reports only the expected public payload byte count.

Verification

  • On macOS, the pinned sign_update with a throwaway Ed25519 key emitted sparkle:length="90" for the fixed 90-byte dummy. The old verifier failed; this patch passed full CryptoKit signature verification; changing the declared length to 91 failed.
  • Windows imported the exact one-commit patch on main 6c5bb67, confirmed its tree and Daniel Boyd identity, and reviewed the literal attribute parser. Swift/CryptoKit execution is supported by the macOS throwaway-key probe; ordinary build CI does not compile this verifier.

This changes only Tools/verify_private_sparkle_keymatch.swift. The Actions secret was not used for the local test. The real key match remains unproven: merging this PR and dispatching another private dummy workflow run each require separate approval. This PR does not sign a DMG, publish an appcast, change a feed, tag, or release.

@danjboyd
danjboyd marked this pull request as ready for review November 11, 2026 18:48
@danjboyd
danjboyd merged commit 5f26db3 into main Nov 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant