Repository navigation
Read Sparkle's namespaced signed length in the key-match verifier - #378
Merged
Merged
Conversation
danjboyd
marked this pull request as ready for review
November 11, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sparkle:lengthattribute fromsign_updateoutput. The previous barelengthlookup failed before the dummy proof reached Ed25519 verification in run 43075103781.Verification
sign_updatewith a throwaway Ed25519 key emittedsparkle:length="90"for the fixed 90-byte dummy. The old verifier failed; this patch passed full CryptoKit signature verification; changing the declared length to 91 failed.6c5bb67, confirmed its tree and Daniel Boyd identity, and reviewed the literal attribute parser. Swift/CryptoKit execution is supported by the macOS throwaway-key probe; ordinary build CI does not compile this verifier.This changes only
Tools/verify_private_sparkle_keymatch.swift. The Actions secret was not used for the local test. The real key match remains unproven: merging this PR and dispatching another private dummy workflow run each require separate approval. This PR does not sign a DMG, publish an appcast, change a feed, tag, or release.