Repository navigation
Match macOS toolbar clicks to the tool under the pointer - #377
Merged
Merged
Conversation
danjboyd
marked this pull request as ready for review
November 11, 2026 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS, clicks near the edge of a toolbar tool could select its neighbor. The custom segmented control mapped clicks by summing
widthForSegment:, which can differ from AppKit's displayed segment boundaries. The Cocoa path now lets AppKit track the click throughsuper mouseDown:. The GNUstep handler is unchanged.The PR also adds an offscreen hit-geometry probe. The Cocoa-only test is excluded from GNUstep compilation.
Evidence
tools-xctestand Tests all built successfully. Windows tests were not run.Limits and release gates
SPARKLE=0build, not a release package or updater test.iconutilto reject the unchanged iconset. The same iconset converted outside that sandbox to an.icnsbyte-identical to the parent build. Release packaging still needs CI qualification.This is a draft PR. Its ordinary PR build CI starts automatically and uses no Sparkle secret. Merging this PR and dispatching any workflow each require separate approval from Dan. No release tag, feed or publication is requested here.