Skip to content

Proof: private Sparkle key match on dummy bytes (0.4, manual, main only) - #376

Merged
danjboyd merged 1 commit into
mainfrom
proof/private-sparkle-keymatch-0.4
Nov 11, 2026
Merged

danjboyd merged 1 commit into
mainfrom
proof/private-sparkle-keymatch-0.4

Conversation

@danjboyd

Copy link
Copy Markdown
Owner

What this adds

A manual check, for review only, that the existing GitHub Actions secret SPARKLE_ED_PRIVATE_KEY matches the app's bundled public key (SUPublicEDKey in Resources/Info-cocoa.plist). It adds three new files and changes nothing else:

  • .github/workflows/private-sparkle-keymatch.yml: the workflow.
  • Tools/verify_private_sparkle_keymatch.swift: the Ed25519 verifier.
  • docs/plans/private-sparkle-keymatch-0.4.md: the plan note.

Commit 82242067546fb98c5fe267c6a885ed712badb8a9 (tree d773b385647c210ce58eb77a81a4ced74376cf5f), on main 01c1ad58677b46774e7bc56ea5f908aaffb637df. 3 files, +140.

What it does and doesn't do

  • Manual and main-only. It's workflow_dispatch only, and the job runs only when github.repository == 'danjboyd/ScreenshotTool' and the ref is refs/heads/main. This PR and its branch can't run it.
  • Dummy bytes only. It signs a fixed dummy payload with the pinned Sparkle 2.10.0 sign_update and verifies the signature against the bundled public key. The signer's hash and the public key are both pinned before the secret is used.
  • The secret. It uses only the existing secret name SPARKLE_ED_PRIVATE_KEY, passed to one signing step. Its value was never read or handled in preparing this PR.
  • Output. It prints only pass/fail and the SHA-256 of the public dummy payload. The signature and any diagnostics stay in a temporary job directory that's deleted even on failure.
  • Nothing is published. No artifact upload, appcast or feed change, Pages deploy, tag or release.
  • A pass would show only that the secret, the pinned signer and the bundled public key agree for the dummy bytes. It wouldn't prove the exact 0.4.0 DMG signature, the appcast, packaging or a live update.

Approvals

This is a draft for review. Merging it and dispatching the workflow each need their own separate approval from Dan. Neither is authorized by this PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AEr1tY2QmxWFSoDkDHs2DC

@danjboyd
danjboyd marked this pull request as ready for review November 11, 2026 17:52
@danjboyd
danjboyd merged commit 6c5bb67 into main Nov 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant