Repository navigation
Proof: private Sparkle key match on dummy bytes (0.4, manual, main only) - #376
Merged
Merged
Conversation
danjboyd
marked this pull request as ready for review
November 11, 2026 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
A manual check, for review only, that the existing GitHub Actions secret
SPARKLE_ED_PRIVATE_KEYmatches the app's bundled public key (SUPublicEDKeyinResources/Info-cocoa.plist). It adds three new files and changes nothing else:.github/workflows/private-sparkle-keymatch.yml: the workflow.Tools/verify_private_sparkle_keymatch.swift: the Ed25519 verifier.docs/plans/private-sparkle-keymatch-0.4.md: the plan note.Commit
82242067546fb98c5fe267c6a885ed712badb8a9(treed773b385647c210ce58eb77a81a4ced74376cf5f), on main01c1ad58677b46774e7bc56ea5f908aaffb637df. 3 files, +140.What it does and doesn't do
workflow_dispatchonly, and the job runs only whengithub.repository == 'danjboyd/ScreenshotTool'and the ref isrefs/heads/main. This PR and its branch can't run it.sign_updateand verifies the signature against the bundled public key. The signer's hash and the public key are both pinned before the secret is used.SPARKLE_ED_PRIVATE_KEY, passed to one signing step. Its value was never read or handled in preparing this PR.Approvals
This is a draft for review. Merging it and dispatching the workflow each need their own separate approval from Dan. Neither is authorized by this PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AEr1tY2QmxWFSoDkDHs2DC