Repository navigation
Windows: a large image's window stays clear of the taskbar - #374
Merged
Merged
Conversation
A 4K image opened 2137x1302 on a 2293x1302 screen, with the status bar under the taskbar. GNUstep's visibleFrame is the whole screen, and the height limit left out the title bar and toolbar. On Windows the limit now comes from the monitor's work area; on GNUstep the title bar and toolbar count, and the centred window is moved clear of the taskbar or a panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, a large image now opens in a window that stays above the taskbar, so the status bar can be seen. On current main, a 4K capture's window runs under the taskbar.
What changes
STWindowsVisibleFramereads it withMonitorFromWindowandGetMonitorInfoW. Before, GNUstep reported the whole screen as the usable area.CanvasStageProbeaddstestWindowForALargeImageFitsTheVisibleFrame.Results
I measured with a 3840×2160 image on Windows 11 at 100% scale. The screen is 2293×1334 and the work area 2293×1286.
CanvasStageProbe: 7 of 7 pass on Windows.Limits
🤖 Generated with Claude Code
https://claude.ai/code/session_01AEr1tY2QmxWFSoDkDHs2DC