Skip to content

Keep result notices clear of redaction highlights - #372

Merged
danjboyd merged 3 commits into
mainfrom
hud-post370-testfix-review
Nov 10, 2026
Merged

danjboyd merged 3 commits into
mainfrom
hud-post370-testfix-review

Conversation

@danjboyd

Copy link
Copy Markdown
Owner

Keep result notices clear of visible redaction highlights, including at low zoom. When the centered notice would cover a highlight, place it at a clear bottom or top position. On macOS, ensure a fading notice orders out while protecting a replacement notice from an older fade callback.

The three commits include the geometry change, the macOS fade fallback, and a test-only coordinate/layout correction: lay out the loaded canvas, assert visibility, and compare the Cocoa child-window HUD and highlight in screen coordinates.

Validation on exact head 1a14a95e5d3b942ccd60968272fb5d5c5da4e069: Linux 18 focused checks pass with no failures or skips. The production-identical parent 6ad17c422c9f8d0dc64ad19043b9bcffcb130479 passed the full Linux suite (367 cases, zero failures/errors, three expected skips). Mac reports the approved native seven-case run on the exact head passed 7/7 with zero failures/skips, unchanged defaults, and restored/released screen state. Track all applicable PR CI before a separate merge decision.

@danjboyd
danjboyd merged commit 4494b96 into main Nov 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant