Repository navigation
Keep result notices clear of redaction highlights - #372
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep result notices clear of visible redaction highlights, including at low zoom. When the centered notice would cover a highlight, place it at a clear bottom or top position. On macOS, ensure a fading notice orders out while protecting a replacement notice from an older fade callback.
The three commits include the geometry change, the macOS fade fallback, and a test-only coordinate/layout correction: lay out the loaded canvas, assert visibility, and compare the Cocoa child-window HUD and highlight in screen coordinates.
Validation on exact head
1a14a95e5d3b942ccd60968272fb5d5c5da4e069: Linux 18 focused checks pass with no failures or skips. The production-identical parent6ad17c422c9f8d0dc64ad19043b9bcffcb130479passed the full Linux suite (367 cases, zero failures/errors, three expected skips). Mac reports the approved native seven-case run on the exact head passed 7/7 with zero failures/skips, unchanged defaults, and restored/released screen state. Track all applicable PR CI before a separate merge decision.