Skip to content

feat(frontend): delete the selected rows with Delete and the cell menu (closes #644) - #649

Merged
danielnuld merged 1 commit into
mainfrom
feat/644-delete-selected-rows
Oct 12, 2026
Merged

danielnuld merged 1 commit into
mainfrom
feat/644-delete-selected-rows

Conversation

@danielnuld

Copy link
Copy Markdown
Owner

Closes #644.

  • Delete key (edit mode): marks the marked rows, or the selected cell's row, for deletion. Pressing it on an all-deleted selection restores them; a mixed selection becomes all-deleted (toggleDeleteRows).
  • Context menu: "Delete row / Delete N rows" (or "Undo delete"), using the same targets as the other row actions. Shown disabled with the reason when the table has no primary key or the grid isn't in edit mode, like "Set NULL".
  • Deletes are only staged: nothing runs before the existing SQL preview, which serves as the confirmation.
  • A row's mark checkbox no longer swallows the grid's row keys. In edit mode the cells are inputs, so the checkbox is how rows get marked, and without this Delete never reached the grid.

Tests: editSession.test.ts (toggleDeleteRows) and ResultGrid.test.tsx (Delete in edit mode from the checkbox; ignored outside edit mode). Typecheck and tests pass. Not yet tried in the running app.

…menu

In edit mode, Delete marks the marked rows (or the selected cell's row) for
deletion, and pressing it again on an all-deleted selection restores them.
The context menu gets the same entry, disabled with its reason when the
grid is read-only or not in edit mode. Nothing runs before the existing SQL
preview. A row's mark checkbox no longer swallows the grid's row keys.

closes #644
@danielnuld
danielnuld merged commit e7f03f5 into main Oct 12, 2026
13 checks passed
@danielnuld
danielnuld deleted the feat/644-delete-selected-rows branch October 12, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(frontend): delete selected row(s) from the grid via Delete key and context menu

1 participant