Repository navigation
feat(frontend): delete the selected rows with Delete and the cell menu (closes #644) - #649
Merged
Merged
Conversation
…menu In edit mode, Delete marks the marked rows (or the selected cell's row) for deletion, and pressing it again on an all-deleted selection restores them. The context menu gets the same entry, disabled with its reason when the grid is read-only or not in edit mode. Nothing runs before the existing SQL preview. A row's mark checkbox no longer swallows the grid's row keys. closes #644
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #644.
toggleDeleteRows).Tests:
editSession.test.ts(toggleDeleteRows) andResultGrid.test.tsx(Delete in edit mode from the checkbox; ignored outside edit mode). Typecheck and tests pass. Not yet tried in the running app.