Skip to content

fix(tools): MemoryGraph no longer crashes on an empty corpus #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pai-scaffolde wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tools): MemoryGraph no longer crashes on an empty corpus #2111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions LifeOS/install/LIFEOS/TOOLS/MemoryGraph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,10 @@ function computePatterns(graph: Graph) {
// Communities (Louvain)
louvain.assign(graph, { resolution: 1 });

// PageRank (influence) + degree
pagerank.assign(graph, { getEdgeWeight: "weight" });
// PageRank (influence) + degree. graphology's power iteration never converges
// on an empty graph (it throws "failed to converge"), and a fresh install has
// no notes yet — skip it there; every reader below iterates zero nodes.
if (graph.order > 0) pagerank.assign(graph, { getEdgeWeight: "weight" });

const degree = new Map<string, number>();
graph.forEachNode((n) => degree.set(n, graph.degree(n)));
Expand Down