docs(Update): correct which update legs work offline - #2102
Open
hifiguy wants to merge 1 commit into
Open
Conversation
Update.md's "Network unreachable" branch says to re-run "the additive legs that work from the on-disk skill (steps 4-6)", singling out step 3 as the only one needing a fetched payload. Steps 4 and 5 do not work either. On an installed system install/ is bootstrap-only -- the doc says so itself one sentence later -- and: - step 4, InstallHooks.ts, reads install/hooks/hooks.json - step 5, ScaffoldUser.ts, reads install/USER/ Neither exists in a bootstrap-only payload, so both exit ok:false. Only step 6, ActivateImports.ts, runs offline; it reads CLAUDE.md, not the payload. Reproduced clean-room against the v7.40.4 release alone -- skill-root set to the installed copy it ships (LifeOS/install/skills/LifeOS), config-root a scratch dir holding only a CLAUDE.md copied from install/CLAUDE.template.md: InstallHooks.ts -> ok:false payload hooks.json not found ScaffoldUser.ts -> ok:false template USER not found ActivateImports.ts -> ok:true OverlaySystem.ts -> ok:false bootstrap-only blocker Three of the four refuse; the doc predicts one. The wording now names step 6 as the only offline leg, says steps 3-5 all require the fetch, and quotes the two additional refusal messages so they read as expected behaviour rather than a broken install. Applied to both copies of the file, byte-identical on main: LifeOS/Workflows/Update.md and the nested installed copy at LifeOS/install/skills/LifeOS/Workflows/Update.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workflows/Update.md's Network unreachable branch tells the operator to"stop after re-running the additive legs that work from the on-disk skill
(steps 4–6)", and names step 3's overlay as the one leg that needs a fetched
payload.
Steps 4 and 5 don't work offline either — and the same sentence explains why,
one clause later: on an installed system
install/is bootstrap-only.InstallHooks.ts, readsinstall/hooks/hooks.jsonScaffoldUser.ts, readsinstall/USER/Neither path exists in a bootstrap-only payload, so both exit
ok: false.Step 6,
ActivateImports.ts, is the only leg that actually runs — it editsCLAUDE.mdand needs no payload.Reproduction
Clean-room, against the shipped skill only — no install required. Extract the
v7.40.4 release, point
--skill-rootat the installed copy it ships(
LifeOS/install/skills/LifeOS, whoseinstall/holds only the five bootstrapfiles), and
--config-rootat a scratch dir containing just aCLAUDE.mdcopied from
install/CLAUDE.template.md:Three of the four steps refuse; the doc predicts only one. Step 6 is the sole
survivor, and only because it reads
CLAUDE.mdrather than the payload.Why it's worth fixing
The offline branch currently sends the operator into two hard failures with no
warning that they're expected.
OverlaySystem's refusal is explicitlypre-labelled "expected, not a failure" — the other two aren't, so they read as
a broken install. An operator debugging that is likely to go looking for damage
that isn't there, or to start hand-copying payload files to make the steps pass,
which is how stale trees get created.
Fix
Documentation only, one line, no code change. The wording now:
Applied to both copies of the file, which are byte-identical on
main:LifeOS/Workflows/Update.mdLifeOS/install/skills/LifeOS/Workflows/Update.mdNotes
No existing issue or PR covers this. The nearest neighbours — #1950
(
OverlaySystem's system-tree list drift) and #1770 (copyMissingcan't updatesystem-owned files) — are both closed and describe different mechanics.
GitHub: @hifiguy · Discord: SecDude2469