Tests for the memory reviewer overwrite fix - #2098
Open
hjbrandt wants to merge 2 commits into
Open
Conversation
The reviewer reads the two memory files, thinks for a few minutes, then writes back a full replacement. Any change made to a file during those minutes was erased. Now the reviewer keeps a fingerprint of what it read and skips the write if the file has changed since. Skipped writes are logged and shown by the memory health check for 24 hours.
13 cases, each in its own process with a temporary home folder, so real memory files are never touched. The replay case fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for #2097, and built on top of it.
There are 13 cases. Each one runs in its own process with a temporary home folder, so the real memory files are never touched. One of them replays the original problem, and it fails on the code without the fix.
There are no other test files in the repo yet, so I kept these separate. Happy to move them or drop them.