Skip to content

fix(AlgorithmNudge): re-arm the late-ISA row on a tool-call budget (#2074) #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bowlerjim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(AlgorithmNudge): re-arm the late-ISA row on a tool-call budget (#2074) #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions LifeOS/install/hooks/AlgorithmNudge.hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bun
/**
* @version 3.2.2
* @version 3.3.0
* TRIGGER: UserPromptSubmit (routing match, always-on) — also runs on PostToolUse via PostToolObserver and on PostToolUseFailure.
* AlgorithmNudge — the Algorithm live nudge layer ("Events ask the rest").
*
Expand Down Expand Up @@ -81,7 +81,10 @@ const SKILLS_DIR = join(PAI, 'skills');
const INDEX_PATH = join(PAI, 'LIFEOS', 'MEMORY', 'STATE', 'skill-usewhen-index.json');

const STALE_ISA_THRESHOLD = 15; // tool calls with zero ISA edits (run-scoped)
const LATE_ISA_THRESHOLD = 25; // tool calls with NO registered run (always-on, once)
const LATE_ISA_THRESHOLD = 25; // tool calls with NO registered run (always-on)
const LATE_ISA_REARM = 3 * LATE_ISA_THRESHOLD; // re-arm budget while still no run (upstream #2074: the
// only reset lived inside the run-closed branch, so a session
// that never registered a run was nudged once, then never)
const COOLDOWN_MS = 5 * 60 * 1000; // default per-nudge-type
const ROUTE_COOLDOWN_MS = 60 * 60 * 1000; // per-skill routing cooldown
const INDEX_MAX_AGE_MS = 6 * 60 * 60 * 1000;
Expand Down Expand Up @@ -155,6 +158,9 @@ interface NudgeState {
toolCallsSinceISAEditAbs: number;
toolCallsTotal: number;
lateISAFired: boolean;
/** toolCallsTotal at the last late-ISA fire; the row re-arms LATE_ISA_REARM
* calls later while no run is registered (upstream #2074). */
lateISAFiredAtCalls?: number;
/** True while an OPEN run is bound to this session. The open→closed edge
* restarts the untracked-work clock (Forge audit H1). */
runWasOpen?: boolean;
Expand Down Expand Up @@ -212,6 +218,7 @@ function loadState(sessionId: string): NudgeState {
toolCallsSinceISAEditAbs: s.toolCallsSinceISAEditAbs ?? (s as any).toolCallsSinceIsaEditAbs ?? 0,
toolCallsTotal: s.toolCallsTotal ?? 0,
lateISAFired: s.lateISAFired ?? (s as any).lateIsaFired ?? false,
lateISAFiredAtCalls: s.lateISAFiredAtCalls ?? 0,
runWasOpen: s.runWasOpen ?? false,
delegateEvents: s.delegateEvents ?? 0,
primaryEvents: s.primaryEvents ?? 0,
Expand Down Expand Up @@ -830,6 +837,7 @@ export function run(input: HookInput): string | null {

if (active) {
state.runWasOpen = true;
state.lateISAFired = false; // a registered run is the answer the late-ISA row was asking for
// stale-ISA counter
state.toolCallsSinceISAEdit = isISAEdit ? 0 : state.toolCallsSinceISAEdit + 1;
state.toolCallsSinceISAEditAbs = isISAEdit ? 0 : state.toolCallsSinceISAEditAbs + 1;
Expand All @@ -855,14 +863,20 @@ export function run(input: HookInput): string | null {
// CALLS, and 25 of those elapse in under a minute on parallel blocks. It
// also bounds the row when a run's progress oscillates around N/N, which
// reopens and recloses it repeatedly (Forge delta audit M-A, M-B).
if (!state.lateISAFired
// Re-arm on a tool-call budget, not only on run close (upstream #2074):
// a session that never registers a run is exactly the one this row is
// for, and "once" meant one nudge at call 25 then silence for 231 more.
const rearmed = state.lateISAFired
&& (state.toolCallsTotal - (state.lateISAFiredAtCalls ?? 0)) >= LATE_ISA_REARM;
if ((!state.lateISAFired || rearmed)
&& state.toolCallsTotal >= LATE_ISA_THRESHOLD
&& cooled(state, 'late-isa', now)) {
// ALWAYS-ON: late-ISA. This deep with no open run is either genuinely
// trivial-iterative or an unwritten climb (dynamic-range audit: 2h of
// substantive work before the ISA appeared) — or a run that closed and
// kept going, which needs the opposite instruction.
state.lateISAFired = true;
state.lateISAFiredAtCalls = state.toolCallsTotal;
const closed = closedRunFor(sessionId);
const text = closed
? `${LATE_ISA_THRESHOLD}+ tool calls since your run closed at ${closed.progress || 'its last claim'}. The work didn't stop when the ISA did — reopen it with the claims this stretch is actually proving, or scaffold a new one.`
Expand Down