Skip to content

The public-push check can miss the branch you're pushing #2099

Description

@hjbrandt

On a big project, the check only looks at the branch you have open, not the one you're sending. So a secret on another branch could slip through.

I found it from the other side: it blocked my push because of an old branch I had open, even though what I was sending was clean.

The check is in LifeOS/install/hooks/PublicPushGate.hook.ts, around line 119. It should look at the branch being pushed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions