Repository navigation
feat(skills): deliver ticket updates as attachments in a private repository - #453
Merged
danielhanold merged 6 commits intoNov 10, 2026
Conversation
…sitory docket-update-ticket no longer refuses in a private repository. SKILL.md routes visibility private to a new references/private.md, which exports each named file through docket-export as a file request, uploads the attachments first and posts the comment last, and posts no comment when any upload fails. Guards: the old refusal moves to the 0585 row's absent list; two new change_0586_update_ticket_private rows pin the route, the convention clause, the table note, and each delivery rule; TestUpdateTicketSkillIsInline now stats every reference SKILL.md routes to, with a floor requiring both shared.md and private.md. Mutation probes (whitespace-collapsed count before/after; mutated -> restored): a re-add refusal bullet 0/1 red->green; b drop private route 1/0 red->green; c route typo privat.md 1/0 red (stat)->green; d move private.md away 1/gone red->green; e revert convention sentence 1/0 red->green; f1-f10 weaken attachments-first, failed-upload-no-comment, no local path, one-call upload, file request, quiet self-fix, single review stop, confirmation-only report, failed export, credential: each 1/0 red->green.
…mentions Review finding (important): references/private.md is a blocking read in SKILL.md's "## 4. Links and attachments", but mentions are settled later in "## 5. Mentions", which can stop to ask the person. Read literally, the "Attachments first, comment last" bullet let the agent upload files in section 4; a cancel at the mention question then left files on the ticket with no comment, and nothing deletes from a ticket. The bullet now says to upload nothing before the post step (SKILL.md section 6), after mentions are settled and after any go the person gives. The clause is pinned in the change_0586_update_ticket_private sentinel (mutation-tested), the private.md budget row is re-pinned (12/629 -> 12/664), and the embedded asset tree is regenerated.
…ep and ban only docket ADR numbers - SKILL.md post step: the no-draft rule now names the private single stop on a rewrite as its exception (pinned in the change_0586_update_ticket_private sentinel). - references/private.md: the comment writing rule bans docket ADR numbers, not all ADR numbers.
danielhanold
deleted the
feat/post-a-ticket-update-on-request-in-a-private-repository
branch
November 10, 2026 19:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a private repository,
docket-update-ticketno longer refuses. It reads the newreferences/private.mdand delivers the update as attachments plus a comment. Each spec or results file the update names is exported and cleaned throughdocket-exportas a file request, then uploaded at the post step (after mentions are settled). The comment goes last, names the attachments, and keeps the PR as a link. The agent writes the comment under the private-repository writing rule and quietly fixes its own text after a whole-word check. The person is asked once, and only when the export rewrote something. A failed or uncertain upload means no comment is posted; the report names what already landed and the exported file paths.Also in this PR:
skills-and-agents.mdand the glossary describe private delivery.change_0586_update_ticket_privatesentinel; the 0585 refusal phrase moves to theabsentlist; the reference-route check coversprivate.md. All guards were mutation-tested.Review
Reviewed by
docket-review-standard: 1 important and 2 minor findings, all fixed.Human check
The results file lists one Important live check from a private scratch repository against a sandbox Jira project, including a forced upload failure.