Skip to content

feat(skills): deliver ticket updates as attachments in a private repository - #453

Merged
danielhanold merged 6 commits into
mainfrom
feat/post-a-ticket-update-on-request-in-a-private-repository
Nov 10, 2026
Merged

danielhanold merged 6 commits into
mainfrom
feat/post-a-ticket-update-on-request-in-a-private-repository

Conversation

@danielhanold

@danielhanold danielhanold commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0586 — Post a ticket update on request in a private repository

In a private repository, docket-update-ticket no longer refuses. It reads the new references/private.md and delivers the update as attachments plus a comment. Each spec or results file the update names is exported and cleaned through docket-export as a file request, then uploaded at the post step (after mentions are settled). The comment goes last, names the attachments, and keeps the PR as a link. The agent writes the comment under the private-repository writing rule and quietly fixes its own text after a whole-word check. The person is asked once, and only when the export rewrote something. A failed or uncertain upload means no comment is posted; the report names what already landed and the exported file paths.

Also in this PR:

  • Docs: skills-and-agents.md and the glossary describe private delivery.
  • Guards: new change_0586_update_ticket_private sentinel; the 0585 refusal phrase moves to the absent list; the reference-route check covers private.md. All guards were mutation-tested.
  • Budgets updated and the embedded tree regenerated. No binary change.

Review

Reviewed by docket-review-standard: 1 important and 2 minor findings, all fixed.

Finding Severity Disposition
Uploads could run in section 4, before mentions were settled, leaving files on the ticket with no comment if the person cancels important fixed (19bba7e)
SKILL.md's "do not show a draft and wait" contradicted private.md's single review stop on a rewrite minor fixed (f3b5c34)
The writing rule banned all ADR numbers instead of docket ADR numbers minor fixed (f3b5c34)

Human check

The results file lists one Important live check from a private scratch repository against a sandbox Jira project, including a forced upload failure.

…sitory

docket-update-ticket no longer refuses in a private repository. SKILL.md
routes visibility private to a new references/private.md, which exports
each named file through docket-export as a file request, uploads the
attachments first and posts the comment last, and posts no comment when
any upload fails.

Guards: the old refusal moves to the 0585 row's absent list; two new
change_0586_update_ticket_private rows pin the route, the convention
clause, the table note, and each delivery rule; TestUpdateTicketSkillIsInline
now stats every reference SKILL.md routes to, with a floor requiring both
shared.md and private.md.

Mutation probes (whitespace-collapsed count before/after; mutated -> restored):
a re-add refusal bullet 0/1 red->green; b drop private route 1/0 red->green;
c route typo privat.md 1/0 red (stat)->green; d move private.md away
1/gone red->green; e revert convention sentence 1/0 red->green; f1-f10
weaken attachments-first, failed-upload-no-comment, no local path,
one-call upload, file request, quiet self-fix, single review stop,
confirmation-only report, failed export, credential: each 1/0 red->green.
…mentions

Review finding (important): references/private.md is a blocking read in
SKILL.md's "## 4. Links and attachments", but mentions are settled later in
"## 5. Mentions", which can stop to ask the person. Read literally, the
"Attachments first, comment last" bullet let the agent upload files in
section 4; a cancel at the mention question then left files on the ticket
with no comment, and nothing deletes from a ticket.

The bullet now says to upload nothing before the post step (SKILL.md
section 6), after mentions are settled and after any go the person gives.
The clause is pinned in the change_0586_update_ticket_private sentinel
(mutation-tested), the private.md budget row is re-pinned (12/629 ->
12/664), and the embedded asset tree is regenerated.
…ep and ban only docket ADR numbers

- SKILL.md post step: the no-draft rule now names the private single stop on a rewrite as its exception (pinned in the change_0586_update_ticket_private sentinel).
- references/private.md: the comment writing rule bans docket ADR numbers, not all ADR numbers.
@danielhanold
danielhanold merged commit 2206925 into main Nov 10, 2026
1 check passed
@danielhanold
danielhanold deleted the feat/post-a-ticket-update-on-request-in-a-private-repository branch November 10, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant