Skip to content

feat: post a ticket update on request (shared repositories) - #452

Merged
danielhanold merged 9 commits into
mainfrom
feat/post-a-ticket-update-on-request-shared-repositories
Nov 10, 2026
Merged

danielhanold merged 9 commits into
mainfrom
feat/post-a-ticket-update-on-request-shared-repositories

Conversation

@danielhanold

@danielhanold danielhanold commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0585 — Post a ticket update on request (shared repositories)

Adds on-request ticket updates for shared repositories:

  • docket context ticket (context.ticket) is a read-only operation. It returns the ticket link state, the repository visibility, whether an event has happened (and why not), the PR and merge facts, and spec and results links pinned to the metadata commit.
  • docket-update-ticket is a new inline skill. It refuses when no update is possible and otherwise posts a short comment for a person reading the ticket. It mentions people only on an exact single match and reports "posted" only when the connector confirms it.
  • render.LinkContext.BlobURLAtCommit builds the commit-pinned links.
  • The skill is registered with the other inline skills. The docket-export ticket-comment example is fixed, and the tickets.provider/site/project config notes now say what uses them.

Before merging: the results file lists one Important live check, run from another repository against a sandbox ticket project.

Review

Reviewed by docket-review-deep (the diff was over 1500 lines). 0 blockers, 2 important, 3 minor.

# Severity Finding Disposition
1 important A killed change with a pr: reported merge-not-recorded and was told to refresh with docket-status fixed (d196ef0): new killed reason
2 important The lead example used a bold plain-text @ mention, which the skill itself forbids fixed (5bb7268)
3 minor The skill did not say where to read the artifact paths; "one read" contradicted the status lookup fixed (ab87dd3)
4 minor No wording for a stacked-merged change whose parent does not resolve fixed (ab87dd3)
5 minor The glossary said update-ticket works with you before posting fixed (ab87dd3)

…on a killed change

Review finding: ticketEvent fell through to merge-not-recorded for a killed
change carrying pr:, and docket-update-ticket then told the person to refresh
with docket-status, which never records a merge for a killed change. A killed
change now reports the new killed reason for pr_merged and results_completed,
and the skill offers a kill update instead.
…r a typed @-mention

Review finding: docket-update-ticket's lead example opened with a bold
plain-text mention, the stand-in its Mentions rule forbids. The example now
uses <mention: Jane Doe> and says it stands for the ticket system's real
mention. A guard rejects a bold at-mention anywhere in the skill and a typed
at-mention on any example line.
…, and correct the inline-skill glossary

Three minor review findings:

- docket-update-ticket now reads each artifact and the change record at the
  pinned metadata_commit from the metadata worktree
  (git -C <metadata_worktree_path> show <metadata_commit>:<path>), and names
  both its reads: context.ticket and, for a ticket-only request, status.
- The PR-merged row says, when facts.merge.destination_branch is empty, that
  the change merged into its parent change's branch without naming it.
- The glossary no longer claims docket-update-ticket works with you before
  posting; it posts without a draft.

Guard phrases for the new wording join the change_0585 alignment rows
(mutation-tested), the embedded assets are regenerated, and the
update-ticket skill's word budget is re-baselined (1465 -> 1521).
@danielhanold
danielhanold merged commit 3243fa5 into main Nov 10, 2026
7 checks passed
@danielhanold
danielhanold deleted the feat/post-a-ticket-update-on-request-shared-repositories branch November 10, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant