Skip to content

feat: link a change to a ticket - #450

Merged
danielhanold merged 12 commits into
mainfrom
feat/link-a-change-to-a-ticket
Nov 10, 2026
Merged

danielhanold merged 12 commits into
mainfrom
feat/link-a-change-to-a-ticket

Conversation

@danielhanold

@danielhanold danielhanold commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0583 — Link a change to a ticket

Adds a typed ticket link to a change and retires the unused issue: field.

  • New record fields ticket_provider, ticket_id, ticket_url, written together by the new change.link-ticket operation (link, explicit replace, unlink; any status) and accepted by change.create; a linked change gets a Ticket row in ## Artifacts.
  • A hand-edited partial or invalid set is treated as not linked and reported as a ticket-link-invalid warning (never a block); link-ticket replace/unlink can repair any shape.
  • context.implementation exposes a typed ticket; implement-next's PR body carries a Ticket: line from it.
  • Per-repository tickets.* config keys (accepted and validated, no effect yet), documented in .docket.example.yml; a repoguard test keeps them out of docket's own .docket.yml.
  • issue: removed from decode, domain, builder, and repair; docket open --help names the export type ticket.
  • Decision recorded as ADR-0161.

Review

Reviewed by docket-review-deep (bumped from standard: diff over 1500 lines).

# Severity Finding Disposition
1 important link-ticket replace/unlink errored on a mapping/multi-line hand-edited ticket value fixed c241796
2 important tickets.* docs described behaviour no code performs fixed ab35113
3 minor schema_vocab comment misplaced by new vocabulary entry fixed b789797
4 minor no test linked over the three empty ticket keys fixed b789797
5 minor spec-required ADR not yet recorded fixed (ADR-0161, metadata branch)

Note: skill size budgets for docket-convention and docket-implement-next were raised in internal/repoguard/budgets_test.go for the new prose.

…hape ticket value

Review finding: replace: true and unlink: true failed with a plain
unsupported-patch-shape error when a hand-edited ticket value was a
mapping, block scalar, or multi-line scalar, so the ticket-link-invalid
remedy could not be followed. Such an entry is now first reduced to a
valueless key line in place, which the field patcher then fills.
Review finding: the tickets block in .docket.example.yml and the tickets.* rows in
docs/reference/config-keys.md described docket acting on linked tickets, but no command
reads any tickets.* key and linking a change accepts any provider. State current
behaviour instead: the settings have no effect today, and a change's ticket is whatever
its link records.
- Move link_ticket_dispositions above the conflict-resolver comment and
  give it its own comment, so that comment describes resolver_dispositions again.
- Add TestLinkTicketPlanFillsEmptyKeys: linking a record that already carries
  the three valueless ticket keys yields linked with all three values written.
@danielhanold
danielhanold merged commit c824883 into main Nov 10, 2026
1 check passed
@danielhanold
danielhanold deleted the feat/link-a-change-to-a-ticket branch November 10, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant