Repository navigation
feat: link a change to a ticket - #450
Merged
Merged
Conversation
…hape ticket value Review finding: replace: true and unlink: true failed with a plain unsupported-patch-shape error when a hand-edited ticket value was a mapping, block scalar, or multi-line scalar, so the ticket-link-invalid remedy could not be followed. Such an entry is now first reduced to a valueless key line in place, which the field patcher then fills.
Review finding: the tickets block in .docket.example.yml and the tickets.* rows in docs/reference/config-keys.md described docket acting on linked tickets, but no command reads any tickets.* key and linking a change accepts any provider. State current behaviour instead: the settings have no effect today, and a change's ticket is whatever its link records.
- Move link_ticket_dispositions above the conflict-resolver comment and give it its own comment, so that comment describes resolver_dispositions again. - Add TestLinkTicketPlanFillsEmptyKeys: linking a record that already carries the three valueless ticket keys yields linked with all three values written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a typed ticket link to a change and retires the unused
issue:field.ticket_provider,ticket_id,ticket_url, written together by the newchange.link-ticketoperation (link, explicit replace, unlink; any status) and accepted bychange.create; a linked change gets a Ticket row in## Artifacts.ticket-link-invalidwarning (never a block);link-ticketreplace/unlink can repair any shape.context.implementationexposes a typedticket; implement-next's PR body carries aTicket:line from it.tickets.*config keys (accepted and validated, no effect yet), documented in.docket.example.yml; a repoguard test keeps them out of docket's own.docket.yml.issue:removed from decode, domain, builder, and repair;docket open --helpnames the export typeticket.Review
Reviewed by
docket-review-deep(bumped from standard: diff over 1500 lines).tickets.*docs described behaviour no code performsNote: skill size budgets for docket-convention and docket-implement-next were raised in
internal/repoguard/budgets_test.gofor the new prose.