Repository navigation
chore: retire the saved Bash upgrade test cases - #448
Merged
danielhanold merged 4 commits intoNov 8, 2026
Merged
danielhanold merged 4 commits into
danielhanold merged 4 commits into
Conversation
danielhanold
deleted the
chore/retire-the-saved-bash-upgrade-test-cases-when-stable-v1-0-0
branch
November 8, 2026 13:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stable v1.0.0 has shipped, so the saved Bash v0.9.2/v0.9.3 upgrade test cases are no longer needed. This PR retires them:
testdata/bash-upgrade/,internal/bashupgrade/,tests/test_go_integration_bashupgrade.sh, the shard's runtime-budgets row, and the matchingtestdata/README.mdsection.TestAliasInvocationMatchesDocketintocmd/docket, reusing the binaryTestMainalready builds.docs/release/upgrading-from-bash.mdso it describes only the upgrade: removes the 20 step markers and every sentence about the retired test. No upgrade step, command, or table changes.Point-in-time records that mention the test are left untouched.
Review
Reviewed by
docket-review-deep(the diff is over 1500 lines, almost all deletions). No findings, so there is no disposition table.Verification
go run ./cmd/docket development test) is green at the head.