Skip to content

fix: rename integration-tag originHasBranch to originHasRef so combined-tag vet compiles - #443

Merged
danielhanold merged 2 commits into
mainfrom
fix/fix-duplicate-originhasbranch-breaking-combined-tag-go-vet
Oct 22, 2026
Merged

danielhanold merged 2 commits into
mainfrom
fix/fix-duplicate-originhasbranch-breaking-combined-tag-go-vet

Conversation

@danielhanold

@danielhanold danielhanold commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0577 — Fix duplicate originHasBranch breaking combined-tag go vet

Renames the integration-tag test helper originHasBranch to originHasRef in internal/app/leak_check_private_integration_test.go. The rename covers its declaration, its doc comment and every caller, including one call in finalize_cleanup_integration_test.go. As a result, go vet -tags integration,e2e ./... compiles again. Before this change it failed with originHasBranch redeclared because the e2e-tagged finalize_e2e_test.go declares a helper with the same name. That e2e helper is untouched. No behavior changes.

Verification

  • go vet -tags integration,e2e ./... exits 0 (it exited 1 before the fix). Each tag alone still vets clean.
  • The whole suite (go run ./cmd/docket development test) passed at the head.

Review

Tier: docket-review-lean (the build routed only to the economy tier, and the diff is 16 lines). Findings: none.

Finding Disposition
(none) n/a

@danielhanold
danielhanold merged commit 2dcf560 into main Oct 22, 2026
1 check passed
@danielhanold
danielhanold deleted the fix/fix-duplicate-originhasbranch-breaking-combined-tag-go-vet branch October 22, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant