Repository navigation
fix: rename integration-tag originHasBranch to originHasRef so combined-tag vet compiles - #443
Merged
danielhanold merged 2 commits intoOct 22, 2026
Conversation
danielhanold
deleted the
fix/fix-duplicate-originhasbranch-breaking-combined-tag-go-vet
branch
October 22, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the integration-tag test helper
originHasBranchtooriginHasRefininternal/app/leak_check_private_integration_test.go. The rename covers its declaration, its doc comment and every caller, including one call infinalize_cleanup_integration_test.go. As a result,go vet -tags integration,e2e ./...compiles again. Before this change it failed withoriginHasBranch redeclaredbecause the e2e-taggedfinalize_e2e_test.godeclares a helper with the same name. That e2e helper is untouched. No behavior changes.Verification
go vet -tags integration,e2e ./...exits 0 (it exited 1 before the fix). Each tag alone still vets clean.go run ./cmd/docket development test) passed at the head.Review
Tier: docket-review-lean (the build routed only to the economy tier, and the diff is 16 lines). Findings: none.