Repository navigation
refactor: retire claim reclaim and its lease - #442
Merged
Merged
Conversation
- docket-status: the intentional-skip sentence names its remaining examples again, snapshot-retained (policy skip) and snapshot-no-work (genuine no-op); embedded assets regenerated and the budget row pinned at the exact new count (125/2956). - repoguard: TestReclaimRetiredFromSkills rejects the word "reclaim" in any case or inflection across the four skills that described it, replacing the enumerated reclaim spellings in the change_0575 rows; the claimed_at, lease, and "refreshes the claim" pins stay. - app tests: fixture comments describe the current rule (claimed_at is neither required nor written; legacy lines are ignored), the pointless done-record claimed_at strip steps are gone, and runTrackerInProgressBlob loses its vestigial claimedAt parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes claim reclaim and the claim lease (
claimed_at). Reclaim never fired, and from another clone it could hand back a change that was still being built. A stranded run now recovers only by resuming it by id.What changed
docket change reclaimand the maintenance sweep's reclaim pass.claimed_at. Validation and repair neither require nor forbid it, and old lines are ignored.reclaim.lease_ttlandreclaim.autoare obsolete tombstones: they load in every layer, warn, and are ignored.Deviation from the spec: the
testdata/repositoriessample configs are left unchanged, becausetestdata/README.mdforbids editing them. The tests assert the obsolete-key warnings against those samples instead.Upgrade note
Every machine that shares this repository's metadata needs the new binary before its next claim. An older binary flags new records that lack
claimed_at.Review
Reviewed by
docket-review-deep. Three findings:claimed_atbehaviorFollow-up, not part of this PR:
go vet -tags integration,e2e ./...fails on a duplicateoriginHasBranchthat predates this branch.