Skip to content

refactor: retire claim reclaim and its lease - #442

Merged
danielhanold merged 7 commits into
mainfrom
refactor/retire-claim-reclaim-and-its-lease
Oct 22, 2026
Merged

danielhanold merged 7 commits into
mainfrom
refactor/retire-claim-reclaim-and-its-lease

Conversation

@danielhanold

@danielhanold danielhanold commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0575 — Retire claim reclaim and its lease

Removes claim reclaim and the claim lease (claimed_at). Reclaim never fired, and from another clone it could hand back a change that was still being built. A stranded run now recovers only by resuming it by id.

What changed

  • Deleted docket change reclaim and the maintenance sweep's reclaim pass.
  • Claim, reconcile, and resume-halted stop writing claimed_at. Validation and repair neither require nor forbid it, and old lines are ignored.
  • The claim result drops its lease fields. Older stored receipts that carry them still decode.
  • reclaim.lease_ttl and reclaim.auto are obsolete tombstones: they load in every layer, warn, and are ignored.
  • Skills and docs describe resume-by-id as the only recovery. Embedded skill copies are regenerated.
  • ADR-0160 supersedes ADR-0159.

Deviation from the spec: the testdata/repositories sample configs are left unchanged, because testdata/README.md forbids editing them. The tests assert the obsolete-key warnings against those samples instead.

Upgrade note

Every machine that shares this repository's metadata needs the new binary before its next claim. An older binary flags new records that lack claimed_at.

Review

Reviewed by docket-review-deep. Three findings:

# Severity Finding Disposition
1 minor docket-status skill lost its intentional-skip example fixed (2a91537)
2 minor reclaim absence pins listed spellings, not the word's shape fixed (2a91537)
3 minor test comments/fixtures still described retired claimed_at behavior fixed (2a91537)

Follow-up, not part of this PR: go vet -tags integration,e2e ./... fails on a duplicate originHasBranch that predates this branch.

- docket-status: the intentional-skip sentence names its remaining
  examples again, snapshot-retained (policy skip) and snapshot-no-work
  (genuine no-op); embedded assets regenerated and the budget row pinned
  at the exact new count (125/2956).
- repoguard: TestReclaimRetiredFromSkills rejects the word "reclaim" in
  any case or inflection across the four skills that described it,
  replacing the enumerated reclaim spellings in the change_0575 rows;
  the claimed_at, lease, and "refreshes the claim" pins stay.
- app tests: fixture comments describe the current rule (claimed_at is
  neither required nor written; legacy lines are ignored), the pointless
  done-record claimed_at strip steps are gone, and
  runTrackerInProgressBlob loses its vestigial claimedAt parameter.
@danielhanold
danielhanold merged commit f0dbb18 into main Oct 22, 2026
7 checks passed
@danielhanold
danielhanold deleted the refactor/retire-claim-reclaim-and-its-lease branch October 22, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant