Skip to content

feat: stop implement-next tripping over its own bookkeeping (0360) - #441

Merged
danielhanold merged 9 commits into
mainfrom
feat/cut-implement-next-coordination-tax-context-after-claim-sess
Oct 21, 2026
Merged

danielhanold merged 9 commits into
mainfrom
feat/cut-implement-next-coordination-tax-context-after-claim-sess

Conversation

@danielhanold

@danielhanold danielhanold commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0360 — Stop implement-next tripping over its own bookkeeping

Summary

Implement-next runs were failing on their own bookkeeping. This change fixes the causes:

  • docket context implementation --id now serves an in-progress change: the full bundle with claim_eligible: false, the recorded branch, and the halt marker (ADR-0158).
  • docket change refresh-claim is deleted. The lease is stamped by claim, reconcile, and resume-halted (ADR-0159).
  • docket schema <id> is accepted as a positional argument.
  • repository.prepare drops the dead skills field.
  • Skill prose:
    • local revision lookups before each write, with a re-sync-once retry
    • far fewer re-syncs
    • minimal "nothing changed" reconcile wording
    • the evidence file is the receipt's block text, with no separate verify call
    • docket-adr records the ADR number on the change in the same commit
    • the review-size bump diffs against the effective base
    • PR-body assembly moved into Step 7

Review

Reviewed by docket-review-standard.

# Severity Finding Disposition
1 minor Step 7 still called the evidence "verified" after the verify call was removed fixed (21d18b6)
2 minor Code comments narrated the deleted operation's history fixed (21d18b6)

Testing

The full suite (go run ./cmd/docket development test) is green at 21d18b6. Focused RED/GREEN and mutation checks were run per task.

- skills/docket-implement-next Step 7 names the Step 6 evidence file (the
  evidence.record receipt's block text) instead of 'verified evidence
  bytes'; regenerated embedded assets; skill word budget 8835 -> 8841.
- RefreshClaim and change_claim.go header comments keep only current
  behaviour (callers change.reconcile and change.resume-halted), dropping
  the deletion-history clause.
…ADR in a dangling relates_to

The docket-adr skill showed adr.record and adr.supersede without --repo-dir
or --json, so an agent running from outside the repository got a bare
invalid-input with no reason. A dangling relates_to finding also carried no
related record, so its text named change 0000 instead of the missing ADR.
@danielhanold
danielhanold merged commit 657c48a into main Oct 21, 2026
7 checks passed
@danielhanold
danielhanold deleted the feat/cut-implement-next-coordination-tax-context-after-claim-sess branch October 21, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant