Repository navigation
test(app): run-cancel worktree test waits for the launch claim to be released - #438
Merged
danielhanold merged 2 commits intoOct 20, 2026
Merged
Conversation
danielhanold
deleted the
chore/flaky-and-failing-tests-standing-bucket
branch
October 20, 2026 12:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docket change 0569. Test-only.
TestIntegrationRunCancelFreesWorktreeForNextStartcancelled as soon as the suite's manifest saidrunning. The launcher (launchScopeless) still holds the drive's launch claim at that point, throughattachLaunch, untilclaim.close(). A cancel in that gap correctly reportscancellation-pending/claim-busy(ADR-0132). Under the parallel suite the gap widens and the test flakes.The test now waits, with a bounded deadline and short poll, until the production read-only launch census reports
run-live:<drive>and noclaim-busy:<drive>, and only then cancels. Every assert is unchanged, and no production code changed.Proof: with a temporary 400 ms delay before
claim.close()(never committed), the old test went red (cancellation-pending,claim-busy) and the fixed test stayed green. Without the delay, the fixed test passed 50 of 50 runs (-tags integration -count=50). A repo-wide sweep found no other test with the same shape. The full suite is green at the build gate.Review