Skip to content

refactor: retire trivial — every build-ready change has a spec - #436

Merged
danielhanold merged 12 commits into
mainfrom
refactor/retire-trivial-every-build-ready-change-has-a-spec
Oct 20, 2026
Merged

danielhanold merged 12 commits into
mainfrom
refactor/retire-trivial-every-build-ready-change-has-a-spec

Conversation

@danielhanold

@danielhanold danielhanold commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0573 — Retire trivial: every build-ready change has a spec

Change #573 — a change is build-ready only when it has a spec. trivial leaves the domain model, the change.groom outcomes, the board, docket open, new records, and all skill, agent and doc prose. Legacy trivial: true lines are inert data. ADR-0155 supersedes ADR-0006.

Review dispositions

Deep-tier review, 1 finding.

# Severity Finding Disposition
1 minor The no-trivial prose guards listed specific spellings, so they missed the old forms (for example "a trivial verdict") fixed (cbc393a): TestGroomSkillsNeverSayTrivial checks the whole word "trivial" in any case, and a mutation check proves it goes red

@danielhanold
danielhanold force-pushed the refactor/retire-trivial-every-build-ready-change-has-a-spec branch from 12bab98 to b3732c0 Compare October 20, 2026 10:39
@danielhanold
danielhanold merged commit 731b8ed into main Oct 20, 2026
1 check passed
@danielhanold
danielhanold deleted the refactor/retire-trivial-every-build-ready-change-has-a-spec branch October 20, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant