Repository navigation
refactor: retire trivial — every build-ready change has a spec - #436
Merged
danielhanold merged 12 commits intoOct 20, 2026
Merged
danielhanold merged 12 commits into
danielhanold merged 12 commits into
Conversation
…mplemented change
…es link reachInProgress linked a spec on each build-ready record but never wrote the spec file, so implementation context refused the dangling link as a missing artifact once build-readiness came to mean a linked spec.
…y shape, not spelling
…ecords link buildReadyChange now links a spec instead of setting trivial: true, so every e2e setup that feeds it to newImplEnv must also write that spec. reachInProgress already did; reachImplemented and the three stacked setups now do too.
danielhanold
force-pushed
the
refactor/retire-trivial-every-build-ready-change-has-a-spec
branch
from
October 20, 2026 10:39
12bab98 to
b3732c0
Compare
danielhanold
deleted the
refactor/retire-trivial-every-build-ready-change-has-a-spec
branch
October 20, 2026 10:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change #573 — a change is build-ready only when it has a spec.
trivialleaves the domain model, thechange.groomoutcomes, the board,docket open, new records, and all skill, agent and doc prose. Legacytrivial: truelines are inert data. ADR-0155 supersedes ADR-0006.Review dispositions
Deep-tier review, 1 finding.
TestGroomSkillsNeverSayTrivialchecks the whole word "trivial" in any case, and a mutation check proves it goes red