Skip to content

feat: let a loop carry on past a halt that concerns only one change - #435

Merged
danielhanold merged 11 commits into
mainfrom
feat/let-a-loop-carry-on-past-a-halt-that-concerns-only-one-chang
Oct 19, 2026
Merged

danielhanold merged 11 commits into
mainfrom
feat/let-a-loop-carry-on-past-a-halt-that-concerns-only-one-chang

Conversation

@danielhanold

@danielhanold danielhanold commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0570 — Let a loop carry on past a halt that concerns only one change

Summary

A tracked implement-next loop now carries on past a halt on a change it picked from the queue, up to run.max_consecutive_halts halts in a row (default 2).

  • New verdict line run-next <key> run-halted <id>: never re-dispatch that change; a loop driver may start a fresh run.
  • At the limit: today's run-stop plus a note asking the person to reset with the new docket run reset-halts.
  • The claim records --selection queue|named. Named runs, resumes, retries, continuations, observe mode and finalize print exactly today's lines, and count faults fall back to today's line. No schema bumps.
  • Docs: one implement loop and one finalize loop at a time. ADR-0154.

Review (deep tier)

Finding Severity State
No test proved --selection reaches ChangeClaimRequest.Selection important fixed (1eedb75)
Halt-count docs contradicted the verdict note on named runs and who runs the reset minor fixed (a15eb56)

Restart sessions after install so the new dispatch block and skill prose load.

Review finding: no test checked that --selection reaches
ChangeClaimRequest.Selection, so dropping the flag copy left the suite
green while every claim recorded an unknown selection. change claim now
dispatches through a changeClaimRunner package seam, and a CLI test runs
the cobra command with --selection queue and asserts the captured request.
…ent wording

Review finding: the docs said a named run never touches the halt count,
but its clean build resets it; and called reset-halts person-only where
the verdict note says it runs on the person's explicit yes.
@danielhanold
danielhanold merged commit 0ea3b6a into main Oct 19, 2026
7 checks passed
@danielhanold
danielhanold deleted the feat/let-a-loop-carry-on-past-a-halt-that-concerns-only-one-chang branch October 19, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant