Repository navigation
feat: put a groomed change on hold so loops skip it - #434
Merged
danielhanold merged 10 commits intoOct 19, 2026
Merged
danielhanold merged 10 commits into
danielhanold merged 10 commits into
Conversation
… accept a held change
…hy on hold section
1. ReadinessKind doc: selection reads Kind == ReadyBuildReady; a named build goes through ClaimEligibility, which also admits ReadyOnHold. 2. Glossary: revise lists the hold among its editable fields and says a hold moves a change between build-ready and on-hold; the Readiness entry says only build-ready changes are selected and a held change is built only when named. 3. docket-groom-next Step 5: a revise keeps the row's readiness unless it sets or lifts a hold. 4. docket-implement-next Step 1: on the named path on-hold also qualifies at the build-readiness confirm. 5. Glossary index: Hold moves to its alphabetical place after Health check. 6. types_test.go: TestLifecycleActionCarriesHold moves after the deliverable test, which gets its doc comment back, with its own comment. Regenerated embedded assets; raised the two moved skill word budgets.
danielhanold
deleted the
feat/mark-a-build-ready-change-as-off-limits-to-the-autonomous-lo
branch
October 19, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A change can now carry
hold: true. Autonomous build selection skips a held change: thestatusready queue,context.implementationwith no id, and id-list drains all leave it out. A run that names that one change still builds it, because the hold changes selection only and never refuses a claim. A malformed value reads as held.change.groom(spec, trivial, revise and re-enable outcomes) andchange.createacceptholdandhold_reason. The reason goes in an operation-owned## Why on holdsection, and lifting the hold removes it. New refusal codes:invalid-hold,hold-reason-without-hold,invalid-hold_reason.build-ready/on hold). The In progress column is renamed State and readsbuilding/run halted — needs you.Review
Whole-branch review, deep tier: 6 minor findings, all fixed in one batch commit.
ReadinessKinddoc comment implied only build-ready is buildable