Skip to content

feat: put a groomed change on hold so loops skip it - #434

Merged
danielhanold merged 10 commits into
mainfrom
feat/mark-a-build-ready-change-as-off-limits-to-the-autonomous-lo
Oct 19, 2026
Merged

danielhanold merged 10 commits into
mainfrom
feat/mark-a-build-ready-change-as-off-limits-to-the-autonomous-lo

Conversation

@danielhanold

@danielhanold danielhanold commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

↩ Change 0560 — Put a groomed change on hold so loops skip it

Summary

A change can now carry hold: true. Autonomous build selection skips a held change: the status ready queue, context.implementation with no id, and id-list drains all leave it out. A run that names that one change still builds it, because the hold changes selection only and never refuses a claim. A malformed value reads as held.

  • change.groom (spec, trivial, revise and re-enable outcomes) and change.create accept hold and hold_reason. The reason goes in an operation-owned ## Why on hold section, and lifting the hold removes it. New refusal codes: invalid-hold, hold-reason-without-hold, invalid-hold_reason.
  • Board: the Groomed table gains a Readiness column (build-ready / on hold). The In progress column is renamed State and reads building / run halted — needs you.
  • Skills, user docs, and ADR-0153 describe the hold.

Review

Whole-branch review, deep tier: 6 minor findings, all fixed in one batch commit.

# Finding State
1 ReadinessKind doc comment implied only build-ready is buildable fixed (5650c88)
2 Glossary revise/Readiness entries misstated hold behavior fixed (5650c88)
3 groom-next said a revise always keeps the row's readiness fixed (5650c88)
4 implement-next Step 1 "confirm build-readiness" ignored a named held change fixed (5650c88)
5 Glossary index entry for Hold out of alphabetical order fixed (5650c88)
6 Test inserted between another test and its doc comment fixed (5650c88)

1. ReadinessKind doc: selection reads Kind == ReadyBuildReady; a named
   build goes through ClaimEligibility, which also admits ReadyOnHold.
2. Glossary: revise lists the hold among its editable fields and says a
   hold moves a change between build-ready and on-hold; the Readiness
   entry says only build-ready changes are selected and a held change is
   built only when named.
3. docket-groom-next Step 5: a revise keeps the row's readiness unless it
   sets or lifts a hold.
4. docket-implement-next Step 1: on the named path on-hold also qualifies
   at the build-readiness confirm.
5. Glossary index: Hold moves to its alphabetical place after Health check.
6. types_test.go: TestLifecycleActionCarriesHold moves after the
   deliverable test, which gets its doc comment back, with its own comment.

Regenerated embedded assets; raised the two moved skill word budgets.
@danielhanold
danielhanold merged commit 9ec9eb2 into main Oct 19, 2026
7 checks passed
@danielhanold
danielhanold deleted the feat/mark-a-build-ready-change-as-off-limits-to-the-autonomous-lo branch October 19, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant