Refactor GuiProgressbar for improved accuracy#2573
Open
oznogon wants to merge 6 commits into
Open
Conversation
GuiProgressbar can fail to show pixels near the min and max values, such as for 98-100% power or coolant on the Power Management screen or the final jump drive charge points in the jump drive controls. This appears to be caused by the GuiProgressbar being filled by a PNG with a transparent border of pixels, which become the only pixels rendered at these extremes, particularly on high-resolution displays. - Remove transparent pixels from edges of the default progress bar fill PNG that caused inaccuracies for values near min and max. Screens that implement GuiProgressbar should manage its width or height using size or margin attributes if necessary. - Conditionally reduce the default width of the fill rect when using a background. This is set to an arbitrary value that approximates the proportions used in existing behavior, but results in a tighter and more accurate fit on high-resolution displays. - Simplify min/max logic using clamps.
A trailing this->value = value immediately overwrites the clamped result, so sliders never enforce their bounds when set programmatically. Remove the extraneous value assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GuiProgressbar can fail to show pixels near the min and max values, such as for 98-100% power or coolant on the Power Management screen or the final jump drive charge points in the jump drive controls.
This appears to be caused by the GuiProgressbar being filled by a PNG with a transparent border of pixels, which become the only pixels rendered at these extremes, particularly on high-resolution displays.
This change retains the fill PNG rather than replacing it with a fill rect so that the bar fill image can still be replaced by mods or themes.
Before
Note how the jump, load, and unload bars appear to be full or empty but aren't.
After
Bars now reach their full extents, and values within 2-3% of empty or full are still visible.
Power Management screen sliders now overflow; the screen has numerous other layout issues (text overlapping controls, bar values not matching slider values) that can also be addressed separately.