Repository navigation
fix: show detected column types and ignore header row in detection - #20
Merged
Merged
Conversation
The type badge was hidden for every column except the sorted one, so only one column looked typed. It now stays visible at reduced opacity. With "1st Row = Header" off, the header text was counted as a sample and pushed sparse columns (one value plus -- elsewhere, e.g. SEC yield, Exp ratio, YTD, 1-10 year) under the 60% threshold. Detection now retries without row 0 when the first pass returns string.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
detectColumnTyperetries without row 0 when the first pass returnsstring, so the header text no longer outvotes sparse columns when "1st Row = Header" is offWhy
On a Fidelity positions CSV only the sorted column showed a type. Detection itself worked for most columns, but the badge was
opacity-0elsewhere, and SEC yield, Exp ratio, YTD and 1-10 year returns fell back to string because the header was one of two samplesHow it was checked
src/main.tsx) on two realPortfolio_PositionsCSVs in both header modes: identical results, SEC yield, Exp ratio and YTD..10 year nowpercent, the SPAXX-only case still detected with header mode onbun build src/main.tsx --outfile=/dev/nullgit diff --check