Repository navigation
fix(csv): keep the fidelity header, signed numbers and safe settings - #19
Merged
Merged
Conversation
- table extraction keeps a header one field shorter than the data rows (trailing comma), two-column files, CR line endings, over-wide rows, and drops a trailing column that is empty everywhere; a bare quote inside a value is text - +1.33%, +$89.08 and $-2.49 are numbers - numeric filters read 1,000, $ and %; a lone ! no longer hides every row; a filter on a column the file does not have is ignored - settings from storage or an imported file are checked field by field - Reset re-saves the remembered data; a failed save clears the stale copy and says so; an emptied column name goes back to the header - export all spaces out the downloads; import keeps the open file
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes from a bug review of the viewer:
Col 40appeared; now the header is kept and the empty trailing column dropped"inside an unquoted value swallowed the rest of the file; two-column files lost their rows when a wider preamble line existed; CR-only line endings; an over-wide row no longer loses its last field+1.33%,+$89.08) were text, so they sorted alphabetically and>0found nothing;$-2.49was positive>1,000was split into>1 OR =0;>$100and5%now work numerically; a lone!hid every row; a filter on a column index the file does not have hid every row of that fileChecks run
bun run build: oksrc/main.tsxrun with bun on a real Fidelity export and small inputs: 14 passed, 0 failedCol 40, no disclaimer rows, data survives Reset + reload): 5 passed, 0 failed; console errors: none