Repository navigation
fix(footer): make the footer the bottom gutter like in gex - #18
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The footer is now the bottom gutter itself, the same way gex does it (
FOOTER_CLASSin gexAttributionFooter.tsx): a box exactly as tall as the side padding (h-4,xl:h-8where the layout usesxl:px-8), text centered in it; the content above has no bottom padding. The last card ends exactly one gutter above the viewport bottom, same as its left and right gap, whatever the footer text isThe previous version added the footer below a full gutter, so the bottom gap was about 42px against 16px on the sides
Checks
bun run build