Remove misleading LanceDB naming#34
Conversation
|
@rchowell , could you help to review this PR, thanks! |
|
Hey @FANNG1 - thanks for the PR! Renaming classes would be breaking change, could you please re-export the existing public class names with a deprecation notice? Thank you. |
|
Thanks for the review. I updated the PR to keep the existing LanceDB-named scan symbols as deprecated compatibility aliases, while the new Lance names remain the preferred ones. Specifically, I kept these old names which in https://github.com/Eventual-Inc/Daft/blob/62cb100858c43a5a92f3bac33d6ecdcefbfa8f8d/daft/io/lance/lance_scan.py#L10-L12:
Each alias now emits a |
a77d7c1 to
8e5f49b
Compare
|
@rchowell This PR has now been rebased onto the latest main and the conflicts have been resolved. Given the current state of the codebase, do you think this naming cleanup is still worth moving forward with, or would you prefer that we close the PR? |
Summary
Closes #33.
Checks
make check-formatpassed.make lintpassed.uv run pytest tests/io/lance -vreported278 passed, 5 skipped, 2 xfailed, 2 xpassed, but the process exited with code 139 after printing the summary.uv run pytest -p no:benchmark tests/io/lance/test_lance_count_pushdown_coverage.py tests/io/lance/test_lance_factory_function.py tests/io/lance/test_lance_point_lookup.py tests/io/lance/test_lance_reads.py -vreported68 passed, 2 skipped, 2 xpassed, but also exited with code 139 after printing the summary.make typecheckfailed on existing mypy issues across tests and a few existing Lance typing mismatches; no failures appeared specific to the naming change.Notes
lancedbtext fromrg -i "lancedb|lance db"is the factual upstream URLhttps://github.com/lancedb/lance/....