Parse negative UNIX timestamps for %Q and %s - #131
Open
maximilliangrand wants to merge 1 commit into
Open
Conversation
The generic numberRe rejects a leading minus sign, so timeParse("%Q")
and timeParse("%s") returned null for any pre-epoch value even though
timeFormat produces negative output for those dates, breaking the
parse(format(date)) round-trip. Use a dedicated signed regex for the two
UNIX timestamp parsers only, leaving the other numeric fields unchanged.
Closes d3#87
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timeFormat("%Q")/timeFormat("%s")emit negative output for pre-epoch dates, but the matching parsers reject a leading minus and returnnull, so theparse(format(date))round-trip breaks:Cause: both UNIX parsers use the generic
numberRe = /^\s*\d+/, which has no sign. As noted in #87, a minus doesn't make sense for the other numeric fields, so this uses a dedicatedsignedNumberRe = /^\s*-?\d+/for the two UNIX timestamp parsers only, leaving every other field unchanged.Round-trip now holds for
%Q,%s, and%s.%Lacross negative and positive values. Added two focused parse tests; full suite (148) and eslint pass.Closes #87