readlink: move ENOENT -> EINVAL logic to syscall wrapper#393
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cyphar
force-pushed
the
proc-readlink-einval
branch
from
53042f9 to
383ba73
Compare
In commit 08856cc ("root: make readlink return -EINVAL for non-symlinks"), we made Root::readlink remap -ENOENT to -EINVAL, but the exact same issue applies to ProcfsHandle::readlink and so we really should just do this in the syscall wrapper to be safe. This also removes the need for errno_mut. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
proc-readlink-einval
branch
from
383ba73 to
09e6e14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #385.In commit 08856cc ("root: make readlink return -EINVAL for
non-symlinks"), we made Root::readlink remap -ENOENT to -EINVAL, but the
exact same issue applies to ProcfsHandle::readlink and so we really
should just do this in the syscall wrapper to be safe.
This also removes the need for errno_mut.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com