Feat/coin selection strategies - #151
Open
Sosthene00 wants to merge 2 commits into
Open
Sosthene00 wants to merge 2 commits into
Sosthene00 wants to merge 2 commits into
Conversation
Sosthene00
force-pushed
the
feat/coin_selection_strategies
branch
from
August 12, 2026 10:34
e3ca307 to
f77c5cc
Compare
Sosthene00
force-pushed
the
feat/coin_selection_strategies
branch
4 times, most recently
from
August 26, 2026 11:37
5417acb to
cf0c6e7
Compare
Sosthene00
marked this pull request as ready for review
August 26, 2026 11:37
Sosthene00
force-pushed
the
feat/coin_selection_strategies
branch
3 times, most recently
from
September 8, 2026 08:40
3d2e376 to
5dcb753
Compare
Sosthene00
force-pushed
the
feat/coin_selection_strategies
branch
4 times, most recently
from
September 17, 2026 20:45
8238cc4 to
3165e06
Compare
Collaborator
Author
|
Significant changes for this new version, trying to make it simpler :
|
Sosthene00
force-pushed
the
feat/coin_selection_strategies
branch
3 times, most recently
from
September 22, 2026 14:57
e03df6f to
1efb1c5
Compare
sdmg15
reviewed
Sep 22, 2026
sdmg15
left a comment
sdmg15
left a comment
Contributor
There was a problem hiding this comment.
tAck 1efb1c5#r4074784031.
Left few nits.
A question: Can we have a more straight function for users that just let them create the transaction but with defaults?
Sosthene00
force-pushed
the
feat/coin_selection_strategies
branch
from
September 23, 2026 11:55
1efb1c5 to
8235f27
Compare
Collaborator
Author
I think we can, but since a lot things will immediately change with introduction of psbt right after this PR I'd rather wait for things to settle before thinking of shortcuts and quality of life functions |
Introduce Changeless, LowestFee, and FeeRateCap BnB strategies with a Greedy fallback, plus a separate DrainSelection for spend-all.
Propose selections independently of building the unsigned transaction, and keep coin_select internals out of the crate's public API.
Sosthene00
force-pushed
the
feat/coin_selection_strategies
branch
from
September 24, 2026 13:04
8235f27 to
20958c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.