Skip to content

test(many-to-many): cover loading HasMany through ManyToMany - #577

Merged
roxblnfk merged 1 commit into
2.xfrom
issue-71-m2m-hasmany-test
Oct 4, 2026
Merged

roxblnfk merged 1 commit into
2.xfrom
issue-71-m2m-hasmany-test

Conversation

@roxblnfk

@roxblnfk roxblnfk commented Oct 4, 2026

Copy link
Copy Markdown
Member

🔍 What was changed

  • Regression test for loading a HasMany relation of entities loaded through a ManyToMany relation: load('posts')->load('posts.comments'), checked with fetchData() and fetchAll() for JOIN, LEFT_JOIN and POSTLOAD.
  • No changes in src/: the bug reported for ORM v1 ("Undefined node") does not reproduce on 2.x, and the test keeps it that way.

Checklist

Regression test for #71: `load('posts.comments')` through a ManyToMany relation failed with "Undefined node" in ORM v1; on 2.x it works with JOIN, LEFT_JOIN and POSTLOAD.

Assisted-By: Claude Opus 5.5
@roxblnfk
roxblnfk merged commit 719fa23 into 2.x Oct 4, 2026
26 of 28 checks passed
@roxblnfk
roxblnfk deleted the issue-71-m2m-hasmany-test branch October 4, 2026 17:24
@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.62%. Comparing base (4dd4ed4) to head (8861148).
⚠️ Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #577   +/-   ##
=========================================
  Coverage     91.62%   91.62%           
  Complexity     2031     2031           
=========================================
  Files           132      132           
  Lines          5277     5277           
=========================================
  Hits           4835     4835           
  Misses          442      442           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot load related entities through many to many relations via LEFT_JOIN

1 participant