Logging fix - D1512#618
Open
droberts-ctrlo wants to merge 4 commits into
Open
Conversation
There was an error in logging.js where the variable 'message' was being re-declared inside the else block, which caused issues when trying to upload the log message. This commit fixes that by using a different variable name for the formatted message before uploading it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix error in logging.js where the message variable is re-declared in the else block of the logging code, causing the code to error when calling outside of a debug environment rather than undergoing the expected behaviour.
NB Unit test was removed due to adding excess complexity to the code - will re-evaluate and look at possible fix