Skip to content

Upgrade dompurify to resolve GHSA-c2j3-45gr-mqc4#598

Merged
cigamit merged 2 commits into
mainfrom
GHSA-c2j3-45gr-mqc4
Jul 22, 2026
Merged

Upgrade dompurify to resolve GHSA-c2j3-45gr-mqc4#598
cigamit merged 2 commits into
mainfrom
GHSA-c2j3-45gr-mqc4

Conversation

@cigamit

@cigamit cigamit commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@cigamit
cigamit requested a review from TheWitness July 21, 2026 20:39
@cigamit cigamit self-assigned this Jul 21, 2026
Copilot AI review requested due to automatic review settings July 21, 2026 20:39
@cigamit cigamit added dependencies Pull requests that update a dependency file SECURITY A security related issue like a CVE specifically javascript Pull requests that update javascript code labels Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • awx/ui/package-lock.json: Generated file

Comment thread awx/ui/package-lock.json
Comment thread awx/ui/package-lock.json
Copilot AI review requested due to automatic review settings July 21, 2026 20:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • awx/ui/package-lock.json: Generated file
Comments suppressed due to low confidence (2)

awx/ui/package-lock.json:13636

  • package-lock.json is not fully in sync with the dompurify upgrade: this hunk updates the node_modules/dompurify entry to 3.4.12, but the top-level packages[""] .dependencies still lists "dompurify": "^3.4.11" (line 19). This can cause npm ci to fail with a lockfile/package.json mismatch. Regenerate the lockfile (or update that top-level dependency entry) so both places reflect ^3.4.12.
    awx/ui/package-lock.json:13636
  • This PR updates the npm package-lock.json. Per the repository guidelines for Node code, dependency updates should be managed with pnpm (and committed as pnpm-lock.yaml) rather than npm/package-lock.json, to keep tooling consistent. Consider migrating the UI dependency management to pnpm as part of this change (or follow up with a dedicated lockfile-migration PR).

@cigamit
cigamit merged commit 2fe3dcc into main Jul 22, 2026
1 check passed
@cigamit
cigamit deleted the GHSA-c2j3-45gr-mqc4 branch July 22, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code SECURITY A security related issue like a CVE specifically

Development

Successfully merging this pull request may close these issues.

3 participants