export public lambda arns to avoid CDK deadly embrace lock in beta deployment#1618
Conversation
|
Warning Review limit reached
More reviews will be available in 52 minutes and 32 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCloudFormation exports for public lookup Lambda ARNs are consolidated from the PublicLookupApiLambdas initializer to parent stacks (ApiLambdaStack and SearchPersistentStack) across compact-connect and cosmetology-app. Dummy exports are removed and replaced with explicit retention exports to prevent "deadly embrace" deployment failures when beta API routes are disabled. ChangesCross-Stack CloudFormation Export Consolidation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/cosmetology-app/stacks/api_lambda_stack/public_lookup_api.py`:
- Around line 46-47: Update the cleanup comment to reference the actual exported
handler symbol: change the TODO/note that currently mentions
SearchPersistentStack.public_handler to point at
SearchPersistentStack.search_handler.public_handler (i.e., the lambda is exposed
as search_handler.public_handler), so the future cleanup targets the correct
handler symbol.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7ca05a1c-af33-42ce-b6bc-4aabd52ad59f
📒 Files selected for processing (4)
backend/compact-connect/stacks/api_lambda_stack/__init__.pybackend/cosmetology-app/stacks/api_lambda_stack/__init__.pybackend/cosmetology-app/stacks/api_lambda_stack/public_lookup_api.pybackend/cosmetology-app/stacks/search_persistent_stack/__init__.py
jlkravitz
left a comment
There was a problem hiding this comment.
@isabeleliassen Good to merge!
We have removed the public API search endpoints from beta (see #1591). The deployment for that change failed due to the 'deadly embrace' issue in CDK where a stack attempts to remove an unneeded export, but CloudFormation can't allow that deletion until the consuming stack of that export has been updated. This adds dummy exports for those lambdas to fix the deployment and allow all the stacks to be updated.
Summary by CodeRabbit