fix(download): keep downloading sources past a failed file - #1116
Draft
bhdnb wants to merge 1 commit into
Draft
Conversation
bhdnb
marked this pull request as draft
September 10, 2026 17:34
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
==========================================
+ Coverage 92.21% 92.22% +0.01%
==========================================
Files 142 142
Lines 11500 11506 +6
==========================================
+ Hits 10604 10610 +6
Misses 896 896 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download sourcesfetched project files one at a time and aborted on the first error. Every file after the failing one went untried, and the files already written were never reported.It now downloads four files at a time and keeps going when one fails, the same way
upload sourcesandupload translationsalready work:--output json|toon|plainstill lists the files that were written, sorted by pathCurrent execution finished with errorsBehaviour changes
runConcurrently, same limit as upload)Difference from Java.
DownloadSourcesActionalso runs in parallel and keeps going, butCrowdinExecutorService.afterExecuteonly prints the error and the command exits 0. That part is deliberately not ported. A run that failed to write files should not exit 0, the same reasoning as #1106.Changes
DownloadCommand.sourcesAction: the sequential loop is replaced withrunConcurrently+reportFailures, and machine-format output is sorted. The--reviewedpath is unchanged, since it only extracts from a local archive.reportFailures/EXECUTION_FINISHED_WITH_ERRORSmove fromupload/uploadFailures.tstocommon/failures.ts, now that download shares them. The two upload imports are updated.translationsActionthat described the old sequential sources loop.