Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Why
Consumers selecting Kubernetes client v0.37 cannot compile crossplane-runtime v1 because its client adapters do not implement the newer Apply interfaces.
Summary
Backports the v2 adapter behavior, including rejecting legacy unstructured wrappers for status Apply. Preserves literal event messages through a constant format string. Adds HTTP-boundary regression tests for payload/options, returned configurations, API conflicts, and unsupported status wrappers.
Evidence
wrapperStatusClient does not implement client.SubResourceWriter (missing method Apply)with the newer dependency graph; regression compilation fails against the pristine v1.20.12 adapter.go test -race ./...passes all 23 test packages on this branch with both Go 1.27.3 and Go 1.26.10.golangci-lint v2.12.2 runpasses with Go 1.26.10.go mod tidy,go mod verify, andgit diff --checkpass.earthly +reviewableremains unchecked: Earthly is unavailable locally and the Docker daemon is not running. Full container generation/checks are pending CI.Merge Danger
Door: Two-way.
Blast Radius: Consumers.
This raises the v1 dependency baseline substantially.
ClientApplicatorembeds two different Apply signatures; callers must select.Clientor.Applicatorexplicitly. This is a draft for compatibility and support-policy review, including whether this belongs on release-1.20. Passing local tests does not establish compatibility for all downstream consumers.Spec
Sources:
PR scope: allow the v1 codebase to compile and pass its unit tests with the newer Kubernetes client graph while preserving explicit legacy-applicator behavior. Minimum-version policy, release approval, and downstream adoption require maintainer agreement.
Contributor checklist
I have:
earthly +reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.DCO sign-off is pending the author's personal attestation; no Signed-off-by certification has been added by automation.