Fix content-length in http/2#211
Merged
Merged
Conversation
The content length header is not set for http/2 requests, as described in croservices#73. This fixes that by calling has-body before setting the headers, which has a side effect of setting the body serializer and the content-length header.
librasteve
approved these changes
Feb 20, 2026
librasteve
left a comment
librasteve
left a comment
Contributor
There was a problem hiding this comment.
This change looks reasonable to me and the code is clean.
Contributor
|
I have reviewed for any nasties (though I am not an expert on HTTP2) - happy for this to be merged. |
Contributor
Author
|
Anything else I can do to help move this forwards? |
Contributor
Author
|
thanks! |
Contributor
Author
|
@japhb or @librasteve, I'd love to see a new version released that includes this bug fix -- anything I can do to help? |
Contributor
|
@bduggan - thanks for the nudge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the content-length header in http/2 -- see #73 and #206