Skip to content

Dedupe E2EE one-time prekeys before unique index #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
creativaPoeta merged 1 commit into from
Jul 22, 2026
Merged

Dedupe E2EE one-time prekeys before unique index #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/database/migrations/20260518000000-add-chat-security-and-e2ee-devices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,30 @@ const removeIndexIfExists = async (queryInterface, tableName, indexName) => {
}
};

const removeDuplicateOneTimePreKeys = async (queryInterface) => {
if (!(await tableExists(queryInterface, "DeviceOneTimePreKeys"))) {
return;
}

await queryInterface.sequelize.query(`
DELETE FROM "DeviceOneTimePreKeys" duplicate_keys
USING (
SELECT
id,
ROW_NUMBER() OVER (
PARTITION BY "userDeviceId", "preKeyId"
ORDER BY
CASE WHEN "usedAt" IS NOT NULL THEN 0 ELSE 1 END,
"createdAt" ASC NULLS LAST,
id ASC
) AS duplicate_rank
FROM "DeviceOneTimePreKeys"
) ranked_keys
WHERE duplicate_keys.id = ranked_keys.id
AND ranked_keys.duplicate_rank > 1;
`);
};

module.exports = {
up: async (queryInterface, Sequelize) => {
await addColumnIfMissing(queryInterface, "Chats", "securityMode", {
Expand Down Expand Up @@ -240,6 +264,8 @@ module.exports = {
await addIndexIfMissing(queryInterface, "DeviceOneTimePreKeys", ["userDeviceId", "usedAt"], {
name: "idx_device_one_time_pre_keys_device_used_at",
});
await removeDuplicateOneTimePreKeys(queryInterface);

await addIndexIfMissing(queryInterface, "DeviceOneTimePreKeys", ["userDeviceId", "preKeyId"], {
name: "idx_device_one_time_pre_keys_device_prekey",
unique: true,
Expand Down
Loading