Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 89.19% 89.22% +0.02%
==========================================
Files 60 60
Lines 5064 5078 +14
Branches 1446 1448 +2
==========================================
+ Hits 4517 4531 +14
Misses 315 315
Partials 232 232 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Update: the CQL operator -> ELM expression mapping in the translator semantics page that I mentioned above might be incorrect, since there are also new ELM expressions mentioned in the Logical Spec that seem like they were intended to be what these new operators map to. If that's the case then there's more work needed here. See https://jira.hl7.org/browse/FHIR-59703 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT because these features are not supported in the translator yet. Do not merge this until the translator is updated and we confirm these work with real ELM.
This PR adds support for the standalone
EquivalentContainsandEquivalentInoperators introduced in CQL 2.0: https://cql.hl7.org/v2.0-changelog.html#equivalent-containsNote that while the
~containsand~inoperators are defined for CodeSystems and ValueSets as well, those translate into the existingInValueSet/InCodeSystem* ELM expressions, see the translation semantics page: https://cql.hl7.org/06-translationsemantics.html#clinical-operators-2 . So this PR is~containsand~infor Lists only.* = Note even though the
InCodeSystemexpression is recognized in cql-execution today, we don't actually support checking whether a code is in a CodeSystem, that would require nontrivial terminology support (#289) which isn't implemented here.Support for the
~containsand~inin the codeComparator of a Retrieve will be a separate PR a) because there's minimal overlap in implementation between these operators and the codeComparators, and b) so that if the translator supports one before the other we can merge the relevant PR without waiting for the rest.The ELM in this PR was manually modified to get the appropriate expressions in place, so run
npm testand notnpm run checkfor now.Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
Submitter:
npm run checkto run tests, lint, and prettier)Reviewer:
Name: