Repository navigation
fix(renovate): let repo-sync alone move the perf-trend workflow pin - #474
Merged
Merged
Conversation
The cosign version and sha256 pair the custom.cosign manager moves now lives only in cplieger/ci's security-scan.yaml: perf-ci.yaml no longer installs cosign. Only the manager's description changes; its pattern and behaviour stay. Ran: python3 -m json.tool default.json (valid).
The synced .github/workflows/perf-trend.yaml carries the cplieger/ci digest pin like the other synced workflow destinations, but the rule that leaves those files to repo-sync did not list it, so Renovate and repo-sync both wrote its pin and it could run ahead of ci.yaml's. Ran: python3 -m json.tool default.json (valid); in the Renovate container, renovate-config-validator --strict passes, a broken key (packageRules[0].matchFileNamez) is named by the validator, and applyPackageRules on cplieger/marotte disables the cplieger/ci pin in perf-trend.yaml (enabled before this change) while agent-publish.yaml's stays enabled and cplieger/ci's own perf-trend.yaml stays enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synced
.github/workflows/perf-trend.yamlcarries the cplieger/ci digest pin, asci.yaml,codeql.yml,release.yamlandsecurity.ymldo, but the rule that leaves those synced files to repo-sync did not list it. Renovate and repo-sync both wrote that pin, so a consumer got a Renovate digest PR and a sync PR for the same line, and the perf-trend pin could run ahead ofci.yaml's. This addsperf-trend.yamlto the rule, so the sync is its only writer.The cosign custom manager's description now names
security-scan.yamlas its one pair site, sinceperf-ci.yamlno longer installs cosign.Tested in the Renovate container:
renovate-config-validator --strictpasses; a misspelled key is named by the validator;applyPackageRulesdisables the cplieger/ci pin in a consumer'sperf-trend.yaml(enabled before this change), keeps an unrelated workflow's pin enabled, and keeps cplieger/ci's ownperf-trend.yamlenabled.