Skip to content

fix(renovate): let repo-sync alone move the perf-trend workflow pin - #474

Merged
cplieger merged 2 commits into
mainfrom
chore/perf-gate-cleanup
Nov 19, 2026
Merged

cplieger merged 2 commits into
mainfrom
chore/perf-gate-cleanup

Conversation

@cplieger

Copy link
Copy Markdown
Owner

The synced .github/workflows/perf-trend.yaml carries the cplieger/ci digest pin, as ci.yaml, codeql.yml, release.yaml and security.yml do, but the rule that leaves those synced files to repo-sync did not list it. Renovate and repo-sync both wrote that pin, so a consumer got a Renovate digest PR and a sync PR for the same line, and the perf-trend pin could run ahead of ci.yaml's. This adds perf-trend.yaml to the rule, so the sync is its only writer.

The cosign custom manager's description now names security-scan.yaml as its one pair site, since perf-ci.yaml no longer installs cosign.

Tested in the Renovate container: renovate-config-validator --strict passes; a misspelled key is named by the validator; applyPackageRules disables the cplieger/ci pin in a consumer's perf-trend.yaml (enabled before this change), keeps an unrelated workflow's pin enabled, and keeps cplieger/ci's own perf-trend.yaml enabled.

The cosign version and sha256 pair the custom.cosign manager moves now
lives only in cplieger/ci's security-scan.yaml: perf-ci.yaml no longer
installs cosign. Only the manager's description changes; its pattern
and behaviour stay.

Ran: python3 -m json.tool default.json (valid).
The synced .github/workflows/perf-trend.yaml carries the cplieger/ci
digest pin like the other synced workflow destinations, but the rule that
leaves those files to repo-sync did not list it, so Renovate and repo-sync
both wrote its pin and it could run ahead of ci.yaml's.

Ran: python3 -m json.tool default.json (valid); in the Renovate
container, renovate-config-validator --strict passes, a broken key
(packageRules[0].matchFileNamez) is named by the validator, and
applyPackageRules on cplieger/marotte disables the cplieger/ci pin in
perf-trend.yaml (enabled before this change) while agent-publish.yaml's
stays enabled and cplieger/ci's own perf-trend.yaml stays enabled.
@cplieger
cplieger merged commit 8e69470 into main Nov 19, 2026
22 checks passed
@cplieger
cplieger deleted the chore/perf-gate-cleanup branch November 19, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant