Repository navigation
feat(renovate): hold toolbelt v4 in marotte and web-terminal-kiro - #470
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toolbelt v4 serves its API through httpserver v2, which changes the error body and how the request id is carried. marotte and web-terminal-kiro still serve through httpserver v1, so a Renovate major to toolbelt v4 would mount a v2 API inside a v1 server. This rule disables the toolbelt v3 to v4 major in those two repositories only. Each one takes v4 by hand in the same change as its own httpserver v2 move and removes its name from the rule.
Checked with the Renovate container's validator (
--strict, plus a broken key that it refuses) andapplyPackageRules: a major ofgithub.com/cplieger/toolbelt/v3is disabled in marotte and web-terminal-kiro, a minor in marotte is untouched, and a major in grelot is untouched.