Skip to content

add test cases of the angle difference #8

Open

Description

@cpanse

problem recmap (<0.5.29):

recmap_debug_rpe

bugfix


        if ((gammaM < 0 && gammaC > 0) || ( gammaM > 0 && gammaC < 0))
          delta = fabs(gammaC + gammaM) / C.size();
        else
          delta = fabs(gammaC - gammaM) / C.size();

testthat

R> set.seed(1); (sapply(1:10, function(i){summary(recmap(checkerboard(8)[sample(64,64),]))[4,]}))
 [1] 0.25 0.23 0.11 0.18 0.26 0.24 0.28 0.30 0.34 0.25

Activity

  1. reopened this on Mar 21, 2018
  2. changed the title [-]do testing angle difference[/-] [+]add testcase of angle difference[/+] on Mar 25, 2018
  3. changed the title [-]add testcase of angle difference[/-] [+]add test cases of the angle difference[/+] on Jun 28, 2019
  4. webbrain-one commented on Aug 22, 2026

    @webbrain-one

    Thanks for flagging this! I opened #23 to address it — it fixes the angle-difference calculation for recmap (<0.5.29) and adds test cases to cover the corrected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions