fix(discovery): variants= dropped from manifest; model= shorthand vs ServerHandle (#378)#55
Merged
Merged
Conversation
…ndle setup params in model= slot resolution (#378)
PaulFidika
added a commit
that referenced
this pull request
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378 (tracker). Two @endpoint API bugs found by the inference-endpoints #343 port:
discover_functionsdeduped manifest entries by(declared_module, class_name, python_name); variant rows share all three with their base function. The stampednameis now part of the dedup key. Repro: any variants-using endpoint's manifest only contained the base function._resolve_single_slotcounted aServerHandle-annotated setup() param as a slot candidate, sosetup(self, model: str, server: ServerHandle)(the docs' engine-hosted example) raised "model= needs exactly one setup() parameter". ServerHandle params are now excluded.Tests: two regressions added; full suite 221 passed, 1 skipped.