Repository navigation
fix(web): pass -config before web in the login service - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start at login wrote
laneway web -no-open -addr … -config <path>into the systemd unit / LaunchAgent.-configis a global flag, so the web command rejected it and the service exited with status 2 on every start. It only showed up when laneway web was started with an explicit-config.The argv now puts
-config <path>beforeweb. The test asserted the broken order; it now checks the order with and without-config. Checked with a built binary: the old order exits 2, the new order starts and serves/api/sessionwith the given config.