Repository navigation
fix(web): keep the comments scrolled in place while their images load - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the Comments tab scrolls to the latest comment (or centres a linked one), but it only re-applied that for about 20 frames. Lazy-loaded images in comments have no reserved height, so one that arrived later made its comment taller and pushed the end away. Cached images didn't, which made it inconsistent.
Both loops are replaced by one
holdthat re-applies the position whenever the comment list changes height (ResizeObserver). It lets go as soon as the user scrolls, clicks or presses a key, or leaves the tab.While the hold is active and untouched, a newly arriving comment also scrolls to the end.
Test: new e2e test with three comments whose images take 800 ms to load. It passes with the fix and ends 947 px from the end when the hold is cut off after 20 frames. The 20 tests in
issue.spec.mjspass. The?comment=path uses the sameholdbut has no test of its own.