Skip to content

fix: pass reconnect intent to browser handoff - #117

Merged
justinhelmer merged 1 commit into
mainfrom
codex/cli-browser-reconnect
Sep 29, 2026
Merged

justinhelmer merged 1 commit into
mainfrom
codex/cli-browser-reconnect

Conversation

@justinhelmer

Copy link
Copy Markdown
Contributor

What changed

  • Forward explicit CLI --reconnect through the browser handoff for GitHub, Slack, Sentry, PostHog, Vercel, PlanetScale, and Supabase.
  • Add command-level URL regression tests for all seven flows.

Why

The CLI bypassed its own existing-connection shortcut but omitted that intent from the console URL. The console could return a false Connected page before new provider consent. Companion console fix: coreplanelabs/nominal#3892.

Verification

  • 8 focused regressions passed.
  • Typecheck, lint, 544/544 tests, build, and diff check passed.

Live acceptance

After both fixes release, repeat the existing PostHog lab-project reconnect and verify the original integration ID updates. Do not treat the Connected page alone as proof.

@coreplane-switchboard coreplane-switchboard Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No verdict submitted — not approving.

Caution

No verdict · head 1675487 · the run ended without a submit_verdict call

Full review

I can’t review switchboard#2474 in this run. The bound checkout is coreplanelabs/cli at 1675487128ea9f979e78169d0e6d1fa46f0688ea, and switching repositories or heads would make the review invalid. No verdict was submitted; #2474 needs a review run bound to e2a24865d50d3a7244fb330afbc159a74e6263ed.

@coreplane-switchboard coreplane-switchboard Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Reconnect intent reaches all seven browser handoffs while ordinary connect URLs remain unchanged.

Note

Approved · head 1675487 · no findings

Full review

No findings at 1675487128ea9f979e78169d0e6d1fa46f0688ea. The reconnect flag reaches all seven browser handoffs without changing ordinary connect URLs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: coreplane-switchboard[bot] reviewed this PR and posted an LGTM verdict (see its review). A repo admin enabled this via the auto-approve workflow.

@justinhelmer
justinhelmer merged commit 7e92e3c into main Sep 29, 2026
5 checks passed
@justinhelmer
justinhelmer deleted the codex/cli-browser-reconnect branch September 29, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant