fix: pass reconnect intent to browser handoff - #117
Conversation
There was a problem hiding this comment.
No verdict submitted — not approving.
Caution
No verdict · head 1675487 · the run ended without a submit_verdict call
Full review
I can’t review switchboard#2474 in this run. The bound checkout is coreplanelabs/cli at 1675487128ea9f979e78169d0e6d1fa46f0688ea, and switching repositories or heads would make the review invalid. No verdict was submitted; #2474 needs a review run bound to e2a24865d50d3a7244fb330afbc159a74e6263ed.
There was a problem hiding this comment.
LGTM: Reconnect intent reaches all seven browser handoffs while ordinary connect URLs remain unchanged.
Note
Approved · head 1675487 · no findings
Full review
No findings at 1675487128ea9f979e78169d0e6d1fa46f0688ea. The reconnect flag reaches all seven browser handoffs without changing ordinary connect URLs.
What changed
--reconnectthrough the browser handoff for GitHub, Slack, Sentry, PostHog, Vercel, PlanetScale, and Supabase.Why
The CLI bypassed its own existing-connection shortcut but omitted that intent from the console URL. The console could return a false Connected page before new provider consent. Companion console fix: coreplanelabs/nominal#3892.
Verification
Live acceptance
After both fixes release, repeat the existing PostHog lab-project reconnect and verify the original integration ID updates. Do not treat the Connected page alone as proof.