fix: avoid duplicate signup terms notice after installer handoff - #115
Merged
Merged
Conversation
![coreplane-switchboard[bot]](https://avatars.githubusercontent.com/in/4630317?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM: Runtime-only handoff preserves direct CLI notices and suppresses the duplicate installer notice without changing signup prompts.
Note
Approved · head 84f329c · no findings
Full review
No findings. The runtime-only handoff suppresses the duplicate installer notice while preserving the notice for direct CLI signup.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The website installer shows Terms and Privacy before its sign-in picker. Its CLI child now accepts a process-scoped
POLYLANE_TERMS_NOTICE_ACK=1handoff, so choosing email signup does not print the same notice twice. Direct CLI signup still shows the notice. The release build keeps this handoff as a runtime value.Companion to website PR #405. Release this CLI change before publishing the updated installer.
Validation
npm run typecheck,npm run lint,npm run test: 532 passed.POLYLANE_TERMS_NOTICE_ACK=1 npm run build: passed; the bundled CLI retains the runtime env read.