Repository navigation
feat(web): shared chat composer with action rail and 16px transcript type (CL-8476) - #893
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Composer(apps/web/src/chat/composer.tsx) used by both the standalone chat thread page and the docked/sub-thread composer in the workbench room page, replacing two near-identical local copies. Behavior is unchanged: Enter sends, Shift+Enter inserts a newline, disabled with the " is starting…" placeholder while no run is live, sends go through the existingstartChat/replyInChat/sendToRoommutations.apps/web/src/chat/threads-api.tsnor the hub API expose a way to cancel a running turn, so cancellation is left out of the rail with a comment pointing at where to add it once that capability exists..chat-thread-body) and composer text to a 16px minimum viamax(var(--text-base), 16px)plusvar(--font-weight-medium), following the same shared-token approach used previously in the deletedpackages/chat-ui/src/styles.css.Verified
bunx tsc -p apps/web --noEmitbun run lint(pre-existing warnings only, inapps/sidecar, unrelated to this change)bun run fmt(no changes needed)cd apps/web && bun run buildcd apps/web && bun run test— 584 pass, 0 failNot verified
Flag for corbitsdev/react-ui
This composer (text field + grouped send/stop action rail, transcript typography tokens) looks like a good candidate to lift into
corbitsdev/react-uias a reusable component, per AGENTS.md's rule that reusable UI belongs there.